Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next #8

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Next #8

wants to merge 17 commits into from

Conversation

gertjanvanzwieten
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #8 (f66bd96) into main (3adb33a) will decrease coverage by 94.60%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #8       +/-   ##
==========================================
- Coverage   94.60%   0.00%   -94.60%     
==========================================
  Files           2       2               
  Lines         500     551       +51     
==========================================
- Hits          473       0      -473     
- Misses         27     551      +524     
Flag Coverage Δ
unittests 0.00% <0.00%> (-94.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nutils_SI.py 0.00% <0.00%> (ø)
tests.py 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gertjanvanzwieten
Copy link
Contributor Author

Corresponding Nutils changes in evalf/nutils#719.

@gertjanvanzwieten gertjanvanzwieten force-pushed the next branch 2 times, most recently from bee89e6 to 207e353 Compare October 14, 2022 11:14
@gertjanvanzwieten gertjanvanzwieten force-pushed the next branch 3 times, most recently from 90a1cb4 to a20e70c Compare October 15, 2022 09:18
@gertjanvanzwieten gertjanvanzwieten force-pushed the next branch 2 times, most recently from c8e5342 to 30c32e3 Compare October 24, 2022 20:36
The patch removes left-over references to Quantity as a univeral constructor, a
role that has been taken over by the parse function.
pyproject.toml Outdated
@@ -14,4 +14,4 @@ dynamic = ["version", "description"]
Home = "https://github.com/evalf/nutils-SI/"

[tool.flit.module]
name = "nutils.SI"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can actually remove the [tool.flit.module] section. It's derived from project.name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants